Julian Knodt

Results 78 comments of Julian Knodt

Hm this is odd, it passes locally again but I'm not sure why it isn't on CI, will I have to only select 64 bit width?

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

No worries, whenever you have time!

*oof* well having it on for all enums is _definitely_ bad, but maybe the discrepancy parameter may make it more tractable. I may experiment with tuning it after reviews

@JohnCSimon It should be ready for reviews now

I finally got around to looking through it, and I think because of its place in the optimization pipeline it wasn't getting hit. I don't think it should be first,...

@matthiaskrgr Is this spurious or a real issue? I've not had a ton of time to look into it

@scottmcm I believe the issues were fixed!

I was looking at the codebase, and was wondering if there was anything more to implement for const generics? I browsed through the linked issue for dimension types, but it...

I was aiming for a volume based centroid, as in the first reference's answer, which also suggests using the origin as the 4th point in each of the tetrahedrons.