RoME.jl icon indicating copy to clipboard operation
RoME.jl copied to clipboard

fixing csm on multiple features test

Open dehann opened this issue 4 years ago • 3 comments

EDIT: better to consolidate this effort with:

  • https://github.com/JuliaRobotics/SensorFeatureTracking.jl/issues/29

dehann avatar Sep 26 '19 02:09 dehann

Codecov Report

Merging #191 into master will decrease coverage by 3.24%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   23.75%   20.51%   -3.25%     
==========================================
  Files          30       36       +6     
  Lines        1486     1711     +225     
==========================================
- Hits          353      351       -2     
- Misses       1133     1360     +227     
Impacted Files Coverage Δ
src/RoME.jl 100.00% <ø> (ø)
src/factors/DynPoint2D.jl 50.00% <0.00%> (+1.02%) :arrow_up:
src/factors/Pose2D.jl 63.63% <ø> (+5.57%) :arrow_up:
src/factors/Bearing2D.jl 30.00% <50.00%> (-5.30%) :arrow_down:
src/factors/BearingRange2D.jl 51.72% <100.00%> (-30.63%) :arrow_down:
src/factors/MultipleFeaturesConstraint.jl 0.00% <0.00%> (-85.97%) :arrow_down:
src/factors/Point2D.jl 53.70% <0.00%> (-9.34%) :arrow_down:
src/factors/Range2D.jl 29.62% <0.00%> (-5.16%) :arrow_down:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98bcda0...1933573. Read the comment docs.

codecov-io avatar Mar 14 '20 22:03 codecov-io

@Affie here is a fun test that used to work way back but broke with CSM at some point. This might already work again, and probably a good stress test while CSM is being updated -- don't let it distract if it's too far out. been commented out for about a year. It's an important test to bring back in the long run though.

dehann avatar Oct 21 '20 05:10 dehann

ah wait this still needs the multihypo= keyword update. Don't add it just yet. good to look at for reference in the mean time.

dehann avatar Oct 21 '20 05:10 dehann