RigidBodyDynamics.jl icon indicating copy to clipboard operation
RigidBodyDynamics.jl copied to clipboard

Updates for compatibility with Rotations.jl `v1.1.0`

Open ferrolho opened this issue 4 years ago • 4 comments

See https://github.com/JuliaGeometry/Rotations.jl/pull/201, from the latest Rotations.jl release https://github.com/JuliaGeometry/Rotations.jl/releases/tag/v1.1.0

ferrolho avatar Nov 30 '21 22:11 ferrolho

Hi, Twan! :)

The CI errors for Julia 1.3 are due to incompatibilities during version resolving of the dependencies. I think this can be solved by bumping up a couple of the deps lagging behind.

As for the Documentation and Julia 1.5 CI errors, those are because this PR depends on https://github.com/rdeits/MeshCat.jl/pull/210 being merged---as hinted by the error message LoadError: type QuatRotation has no field x. This error is only on the notebooks though, the rest of the RBD.jl tests are all passing on my machine.

ferrolho avatar Dec 04 '21 23:12 ferrolho

Okay, I have finally managed to get the CI checks for Julia 1.5 to pass. I think maybe we can drop the Julia 1.3 checks? Ideally though, we should remove both 1.3 and 1.5, and then add checks for Julia 1.6, since that is not the LTS release. (Unless there are other reasons for maintaining 1.3 and 1.5 that I am not aware of.)

ferrolho avatar Jan 14 '22 15:01 ferrolho

Oh, and there's also a slight problem with the Rotations.jl update. I wasn't able to get notebook 6 to work with the new version, as it complains that a Quaternion cannot be created from symbolic variables.

ferrolho avatar Jan 14 '22 15:01 ferrolho

@tkoolen, can you please have a look at this PR, and also at #622 and #616? It would be great if you could merge them and tag a new release. It has been a while since we have tagged a release...

ferrolho avatar Jan 14 '22 15:01 ferrolho

I am going to close this as it has been superseded by #634.

ferrolho avatar May 30 '23 13:05 ferrolho