Julian Grimm
Julian Grimm
I can 100% agree here. Currently working on Sagemaker Code Instances is just not that great, as there is no syntax highlighting and proper intelisense configuration!
Would agree with @josh-gree . As far as I understand the issue is Microsoft made Pylance proprietary, which prevents the installation in unofficial builds of VSCode. With that beeing said,...
Thanks for the review. I agree that the logic is not complete and it needs some more work and I need to figure out all the possible edge cases. Also...
@DudeNr33 Finally ready for review again. All functional tests are passing and the association logic is working correctly now. Interestingly, I figured while playing around that this PR also fixes...
I updated the functional tests, so now this also Closes #9267 The example from #8046 currently produces this output: ```puml @startuml classes_toy_code set namespaceSeparator none class "ExampleClass" as parser.toy_code.ExampleClass {...
Thanks for the review, I appreciate the kind words :) I remember the patch coverage initially dropped because I updated a base class, and only two lines were uncovered at...
Not sure why the workflow hangs?
The same thing is happening for other PRs aswell, so it is definitly not related to the changes. Not sure what is happening here
I reversed the arrows as requested, so the association direction should now be correct. I agree that handling all the nuances of class vs instance attributes would add significant complexity...
Yes thank you! Thats what I meant. Feel free to open a PR on that one :)