Jules Gagnon-Marchand

Results 16 comments of Jules Gagnon-Marchand

Hello. I would propose that this (https://github.com/jakezhaojb/ARAE/issues/8#issuecomment-325054015) be pushed to the main version, if you so desire, because it's been a while. thanks for the help!

Thanks for your contribution. In the state it's in, it really doesn't respect the architectural choices of the original code, and suggests that you didn't take the time to understand...

If you split your contributions into smaller patches that I could review individually, it would be a lot better.

The globals were not super nice to use the library as part of another script instead of just using the script from the command line.

Ah, also, I made it support UTF-8 in python 2

I also have errors with this type of situation. ```python def fn() -> Union[tf.Tensor, Tuple[tf.Tensor, ...]]: ... tensor_or_tuple = fn() if not isinstance(tensor_or_tuple, tf.Tensor): raise RuntimeError(type(tensor_or_tuple)) print(tensor_or_tuple.shape[1]) # pytype complains...

Same for me. ``` (base) jules@MBP-Jules:~/Downloads$ type readarray readarray is a shell builtin (base) jules@MBP-Jules:~/Downloads$ echo $BASH_VERSION 5.1.4(1)-release ```

why did they do this in node

I wanted to mention that this project i very cool by the way!