JoyMonteiro

Results 79 comments of JoyMonteiro

I'm fine with getting rid of x/y_name for now. We don't have a use case where this is not applicable currently, and so this is not something we need to...

Nope, any component that modifies the surface pressure should ensure that the other pressure arrays are consistently changed -- `DcmipInitialConditions` also needs model top pressure. If model top pressure is...

Yes, I have looked through the GFS code. What I'm pointing out is that if the pressure arrays are modified by hand before calling GFS and the model top pressure...

I'm coming around to your point of view that storing the information in the constants dictionary may not be the best approach. Come to think of it, I think this...

not sure what you mean, but if dcmip uses `air_pressure` from state to create its output arrays while modifying `surface_air_pressure`, these arrays will be inconsistent and will error in GFS...

I'm in the middle of something right now, will get to this asap. However, I must note that the order of calling components does matter (it is a known "feature"...

Thanks for this very detailed analysis. It is great to see such an analysis, since it helps improve my own understanding of climt :) Overall, I think the behaviour you...

Another issue that you don't seem to have raised, but I find the temperature profiles a bit off. Can you verify that they are moist adiabatic? I have found that...

This is simply the behaviour of the RRTMG SW code. See the comments in https://github.com/CliMT/climt/blob/69d1e5d7071f248da5c68053ce08af2a11267cd1/climt/_lib/rrtmg_sw/rrtmg_sw_rad.f90#L269-L279 This should be documented better. I will keep this issue open to remind me of...

@RPrudden you are correct that this is a non-trivial task. A lot of code in climt is in Fortran, and there aren't really any good free tools (that I know...