Josiah Parry

Results 91 comments of Josiah Parry

I've had a chance to test this locally. There are a couple of issues. There is a namespace conflict (present in ndarray feature too). So we need to change the...

I spent some time revisiting this PR today. I would quite like to see it merged, however, I think in its current state it just isn't quite there yet. The...

This topic has been raised again today. I think my personal preference on how to handle this would be to completely error out for functions that require the use of...

@Ilia-Kosenkov do you have some time this week to review this PR?

All comments have been resolved, green checks abound. I'm going to merge! Thanks for your patience @CGMossa

Thanks! Re: > "I think rextendr should not modify other than then extedr-wrappers.R. Cargo.toml is supposed to be edited by the package author, so trying to modify it might cause...

Perhaps, if we do not want to conflict with usethis, the function could be something like `sync_crate_version()` which could take the version in the DESCRIPTION file and use it in...

I can confirm that the option worked for me. But I will note that setting the options feels a little odd and I'd _personally_ love an exported function that can...

That all sounds good! Perhaps those functions could already serve my need? I think having an example of them in the README could help clarify their use and intent!

Hey @rakatz42, thanks for the heads up. It looks like you're trying to select from a feature server. But a server is a collection of one or more feature layers....