Josiah Parry

Results 91 comments of Josiah Parry

After giving this a more thorough look, it appears that the local join count is choosing the lesser of the 2 p-values from greater or lesser. Is there a way...

Thank you so much for the added color! Much appreciated. Changing the issue title. Close upon your discretion :)

## Review checklist for @JosiahParry ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

> @JosiahParry pinging you to make sure this review is on your radar! Let me know if you have any questions Yup, it is :) thanks!

I have reviewed this package and at this moment am unable to check off the sections `Substantial Scholarly Effort`, `Functionality Documentation`, `Automated Test`, `Community Guidelines`, and `Quality of the writing`....

It would be great to have a fully supported version of this for ADO. `remotes::install_git()` works inconsistently for packages hosted in ADO. I have one package which installs just fine...

Here is what I've got so far for an implementation. The resultant object is rather wild and wouldn't fit into a data frame mentality without a fair amount of restructuring....

It could be a super easy implementation if we only return info regarding the cluster assignment. If we return info about edges etc that cannot conform to a dataframe structure...

Implemented in spdep main branch p values presently being addressed