Joshua Behrens

Results 144 comments of Joshua Behrens

> Yesterday, I fixed some ESLint issues, and now the code looks good. However, I have run some tests, and they still fail when the < character is included in...

@shyim I rebased and tested again. Works on my machine :/ ![image](https://github.com/shopware/shopware/assets/1133593/960e669f-9a13-45f5-85f4-34c42994aff2)

Yes I know :D but why?! it is green on my machine. What shall I do?

https://github.com/shopware/shopware/pull/1024 I've been there 3 years ago. I suggest to read the feedback I received back then so you can make likely make it happen :)

I rebased, changed ticket in changelog and amend regarding review comments

Ah yes :) finally. I wanted to approach this differently first by debugging and changing `fn_match` :D but I like this a lot

Plugin / Theme Structure like Shopware built around Twig. We had to built something as well and it feels bad to just copy if this could have been solved directly....