Josh Cheek

Results 44 comments of Josh Cheek

This looks unintentional. Looks like you used `knock` as a template for a different gem and accidentally sent a PR.

I guess I'm looking for something conceptually similar to this: ```ruby def diff_if_applied(base_branch, pr_branch) merge_base = git_merge_base base_branch, pr_branch pr_changes = git_diff merge_base, pr_branch base_changes = git_diff merge_base, base_branch pr_changes...

The dot in `./` is your current working directory. In other words, wherever you are in your file system when you ran the program (and it can change as the...

In all honesty, I think it's an antipattern to use relative paths in require statements. If that's what you're wanting, you should use `require_relative`, otherwise you should fix the load...

FWIW, I got it to behave the way I would expect (didn't test much, just playing around): ```diff diff --git a/lib/byebug/processors/pry_processor.rb b/lib/byebug/processors/pry_processor.rb index 57a4ee1..2d3ae78 100644 --- a/lib/byebug/processors/pry_processor.rb +++ b/lib/byebug/processors/pry_processor.rb @@...

> Hi @JoshCheek, thanks for your feedback. I still feel the best resolution for this issue would be to make pry-byebug stop being a pry plugin and make it into...

FWIW, I've had to hack the option parser before, [here](https://github.com/JoshCheek/mrspec/blob/278f0489119ebb31466750a91bd4412374654026/lib/mrspec/add_options_to_rspec_parser.rb). And [here](https://github.com/seattlerb/minitest/blob/e47353d1cb6c82d4e30d3013c965ce70bbdcb429/lib/minitest.rb#L91-L99) is how minitest loads plugins.

I showed how to use Rubygems to do this in https://github.com/rspec/rspec-core/issues/2386#issuecomment-279801577 I should have posted that here, so responding in this thread. @JonRowe replied: > The downside to mini tests...

No particular opinion on whether this should be done (can see arguments on both sides and there's a tv going), but this may be relevant in terms of implementation (not...

A thought in my brain: Current extensions simply ignore the issue, which means you require the code before using them. That wins up in the `.rspec` file or maybe `RSpec.config`,...