Josh Cheek

Results 44 comments of Josh Cheek

Oh, that second one is interesting, it seems to be related to the letter `C`. Put this into your editor, select the `ABCD` and do `Cmd+d` to highlight the second...

Oh, okay, so it's going wonky on the highlighting because it applies "C" language syntax highlighting to it. So syntax highlighting does still get applied, but only sometimes. Maybe there's...

I think [this](https://github.com/atom/language-ruby/commit/437275d) commit is part of the problem. I don't think that change does what it is presumably intended to do. Eg it looks like the author thought it...

Followed the instructions to make changes locally ([here](https://flight-manual.atom.io/hacking-atom/sections/hacking-on-atom-core/) to put atom into dev mode, and [here](https://flight-manual.atom.io/hacking-atom/sections/contributing-to-official-atom-packages/) to link local changes into the dev-mode). Ran a `git-bisect` on it. [This](https://github.com/atom/language-ruby/commit/701ad5d744e23090655f1c2e725f18cfe6f4ae7c) is...

There are apparently multiple grammars which are loaded, and the one that is used is determined by a configuration value. This package uses this feature to test against the old...

Maybe worth noting that "Github Markdown" highlights it correctly (LHS), but Ruby doesn't. ![image](https://user-images.githubusercontent.com/77495/108024351-01e8da80-6fea-11eb-9a1d-6cbaedc5333a.png) The scopes seem really different, almost seems like they don't use the same Ruby parser. ![image](https://user-images.githubusercontent.com/77495/108024730-b84cbf80-6fea-11eb-9692-2e06ba4f2e03.png)

FWIW, I was able to hook into snippet expansion (a proof of concept) by observing the "snippets:expand" event and then checking if the scope matched and one of the cursors...

My opinion is the method is fine and the other code should use it instead of directly referencing the global constant. I generally like that better because I don't like...

I agree that it would be nice if the lib would check that it's not nil, I was similarly confused. Also, I think it's supposed to be `Rails.application.secret_key_base`, otherwise I'm...

+1 The problem is that it lazily creates the `current_user` method lazily when the token is passed. This is done via `method_missing`. If it is called without the token, it...