Jory Hogeveen

Results 131 comments of Jory Hogeveen

Hi @maximajobin, Sounds good but I'm on holiday until the 25th!

Hi @jlsjonas What do you mean with that it wouldn't fit in the current design langauge? This would be an extra for the graph (below or beside it), not a...

Completely understand :) hence I think this should always be opt-in. The Y axis can definitely enhance the UX when aggregating two separate charts (using a secondary entity) but indeed...

@sc0ttkclark Could you give me a bit more info about the nature of this PR? What was the bug and how can I replicate that to make sure this PR...

@sc0ttkclark @pdclark I can confirm this feature to work properly. It saves the value correctly in the database but in order to display the value properly there is more required....

@sc0ttkclark Might be a regression but anything you can quickly think of? Otherwise I'll dive into this one :)

Probably related: https://wordpress.org/support/topic/shortcode-to-check-the-_total/

https://wordpress.org/support/topic/error-editing-existing-podsother-language/#post-15063463 > @sc0ttkclark i have updated to the latest version, no more error thrown, but the fields are missing when editing PODs on another language

@sc0ttkclark After testing I found that the condition below passes as `true` when passing a string value (as taggable does). https://github.com/pods-framework/pods/blob/main/classes/PodsAPI.php#L5734 This is the cause that the whole taggable code...

Nevermind, found it. https://github.com/pods-framework/pods/commit/c84245d5fb076726bf000be48870b290662de07a `/[^0-9]/'` was changed into `'/[^\D]/'` and this changes the behavior for non-numeric strings: `preg_match( '/[^\D]/', 'Test' )` => `0` `preg_match( '/[^0-9]/', 'Test' )` => `1` So...