Jordan Maples

Clarification requested for Expects/Ensures contract violation behavior

45

There have been discussions recently in #1512 and microsoft/GSL#831 regarding contract violation behavior. Would the editors mind clarifying the desired behavior for contract violation and updating GSL.assert as necessary? The...

Should Expects be required to abort?

14

The guidelines say here that GSL Expects always aborts on failure. http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#SS-assertions However, Microsoft's GSL implementation has a mode that can alternatively throw on failure. see here microsoft/GSL#775 which prevents...

consider updating gsl::joining_thread to be std::jthread

5

Microsoft::GSL has yet to implement joining_thread and with std::jthread being standardized, we should consider updating the documentation in the CoreGuidelines to std::jthread. Today the Guidelines only mention C++17 features, this...

gsl::not_null conversion operator

3

An issue raised on the Microsoft/GSL that requests a conversion operator on `gsl::not_null` for non-copy constructible types (Microsoft/GSL#991). Would the Guidelines editors like to see something like this added for...

Is gsl::narrow intended to work with custom arithmetic types?

2

An issue ( Microsoft/gsl#990 ) was recently filed in the Microsoft GSL repository, requesting additional support for `gsl::narrow` on custom arithmetic types. Do the CppCoreGuidelines intend for narrow to support...

Should move_owner be removed from GSL.Util?

2

move_owner no longer exists in the lifetimes paper, should it be removed from the CppCoreGuidelines?

Never delete a move constructor or move assignment operator

5

As quoted from @jwakely in https://github.com/microsoft/GSL/pull/842#issuecomment-673403244 > Never delete a move constructor or move assignment operator. If you want moving to be equivalent to copying then do not write move...

Should gsl::narrow include slicing

1

Re: Microsoft/GSL#917 Should narrow and narrow_cast also apply to slicing, because slicing also allows for going from larger to smaller ranges of value. Both could be considered lossy. Thanks.

Clarification for gsl::dyn_array design

5

There's been a request for the Microsoft GSL to implement dyn_array (microsoft/gsl#890). Would the editors mind providing clarification on it's design and priority. Thanks.

Address not_null design question

2

#379 #399 #509 see also #225 Microsoft/GSL not_null has an implicit conversion from T to not_null which doesn't follow the guidelines explicit conversions. However, making it explicit as the guidelines...