Jordan Henderson

Results 196 comments of Jordan Henderson

Hmm, I can't quite parse what you're saying... All prs (and issues) must have a `comp:*` label - https://github.com/supercollider/supercollider/wiki/Labels-and-milestones-for-PRs-and-Issues Perhaps the comment about commit message format and mandatory labels should...

I could have sworn you could add labels to your own prs and issues... I think I've got another GitHub account somewhere so I'll give it a go and report...

Ah no your right! I wouldn't mention labels then.

Why is `Wno-enum-constexpr-conversion` needed? The scsynth forum post was about a boost error, that seems to be fixed, is this still needed?

@telephon the code here is exactly the same as the previous PR (with the exception of removing the error class). Each commit is broken into a self contained chunk and...

ooooooooo....hadn't thought of that. I'll commit in a second and fix both, should be simple.

@telephon done! It compares the `Method` objects to see if it has been overridden. ``` var thisDoesNotUnderstandWithKeys = this.class.findRespondingMethodFor(\doesNotUnderstandWithKeys); var objDoesNotUnderstandWithKeys = Object.findMethod(\doesNotUnderstandWithKeys); if (thisDoesNotUnderstandWithKeys == objDoesNotUnderstandWithKeys){ .... } ```...

While I've been looking at that (which I will do and seems easy enough), I just discovered an oddity that, causes a very small breaking change, but actually should be...

Right, all done, now it will look for the appropriate `dNU*` method, and the bug with the keyword args has been fixed. There are also some documentation changes that should...