Jordan Henderson

Results 134 comments of Jordan Henderson

Does anyone have any opinions on the state of this PR, if the approach is going to be a separately maintained fork, what should happen to this PR?

Just ran into this today when the gh tests failed but I had formatted on my machine using clang-format-16. Took a long time to find out why... Isn't bumping the...

Any news on this? There is no easy way to install clang-format-8 on arch based systems, and building llvm just for a formatter is a big ask.

Is this change necessary if the precommit is done instead? That seems like a better solution?

> FYI Not contributing to this project anymore, someone else can pick it up. Sorry to see you go Moss, but thank you for the previous comment!

Just force pushed a clean commit. Only does one thing now.

Does anyone know if the object previously at the return slot needs to be free'd manually gc? Edit: no it doesn't

> I would guess not because of GC. But I have a question. When the code runs into a problem, like receiving the wrong type of data or encountering an...

Coming back to this after learning more... in his case no it doesn't because there isn't any point of failure between creating the string and assigning it to a slot,...

I've updated this now with tests and documentation.