Jordan Henderson

Results 134 comments of Jordan Henderson

I've changed the name and tidy things up a little. Still, the code is a little hard, I've often struggled to make these graph algorithms readable with all the recursion.

Ah your right, that isn't a good definition in the help docs. > The definition should come from the implementation. It does a left-first depth-first search recording the size of...

How about... >Returns true if all nested sub arrays are the same size and all elements have the same depth. This is a requirement of several nested array algorithms and...

Another point, Object.shape returns nil, but Object.rank returns 0. Object.shape should really return an empty array to be consistent. That could potentially be breaking though.

So I think this should be it now. A little update. I tried to implement this for SequenceableCollection, adding definitions for shape and rank (breaking changes, but quite small), while...

Thanks for you help @mtmccrea, let me know if there is anything else needed.

> full depth searched because the element types are constrained Actually, nothing needs to be searched these cases, as they cannot be nested as the shape is just `[this.size]`, the...

Just added a c++ optimisation for raw arrays, literally two lines. Now it doesn't loop over the elements of a raw array and just returns the size directly. ``` [...

I've added the tests now.

All CI is now passing, anyone want to review and merge?