Joona Aalto

Results 25 comments of Joona Aalto

I suggested `translation` because I don't consider e.g. lines and planes to have a specific "position"; they can simply be translated relative to the origin. This is probably nitpicking though,...

FYI, `Capsule` was renamed to `Capsule3d` and a `Capsule2d` primitive was added: #11585 It should probably be added as a 2D gizmo too, it'd just be two semicircles and lines...

Should be fixed @alice-i-cecile

I like the look of the actual example, but: - The naming doesn't quite work when using the same enum for 2D and 3D, e.g. this is not a circle:...

Meshing for most 3D primitives was added in #11688, so this example should probably be updated to reflect that

I like the ramp, but the cone should be in a separate PR. Meshing for cones isn't quite as trivial. From what I can see, the cone here uses duplicate...

I think we should also consider re-exporting the primitives so that you don't need `primitives::foo` everywhere. They're meant to be used all over the place, for e.g. meshes, bounding volumes,...

> I'm not a fan of the Facing enum, why not use a Vec3 directly ? like mesh.facing(Vec3::Z), it would allow for more rotation options Yeah, I could maybe do...

Another reason for not having `facing` on `Mesh` is that you'd need to first `build` the mesh, which makes the API slightly less convenient: ```rust // Now meshes.add(Circle::default().mesh().facing_y()) // With...

Gotcha, makes sense. I already made PRs to add transformation methods (#11454) and merging support (#11456) for `Mesh` directly since they're useful to have anyway. It might be a bit...