bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Dedicated primitive example

Open RobWalt opened this issue 5 months ago • 10 comments

I just implemented this to record a video for the new blog post, but I figured it would also make a good dedicated example. This also allows us to remove a lot of code from the 2d/3d gizmo examples since it supersedes this portion of code.

Depends on: https://github.com/bevyengine/bevy/pull/11699

RobWalt avatar Feb 04 '24 14:02 RobWalt

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

github-actions[bot] avatar Feb 04 '24 14:02 github-actions[bot]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

github-actions[bot] avatar Feb 04 '24 14:02 github-actions[bot]

For anyone reviewing this: Please note that I extracted a bugfix which was previously included. The polygon in 2D will be fixed. The bugfix can be found here https://github.com/bevyengine/bevy/pull/11699/commits/f7473ec7216cd4744150ff658b348144f4acd7d5

RobWalt avatar Feb 04 '24 17:02 RobWalt

I like the look of the actual example, but:

  • The naming doesn't quite work when using the same enum for 2D and 3D, e.g. this is not a circle:

not a circle

  • The 2D view doesn't have shape names: (the layout is also a bit different)

no names

  • There are several empty choices in the 2D mode without explanation

empty

Jondolf avatar Feb 05 '24 20:02 Jondolf

I like the look of the actual example, but:

* The naming doesn't quite work when using the same enum for 2D and 3D, e.g. this is not a circle:

not a circle

* The 2D view doesn't have shape names: (the layout is also a bit different)

no names

* There are several empty choices in the 2D mode without explanation

empty

I'm not really sure how to do this (yet?). Somehow it's hard for me to position the text consistently between 2D and 3D views. On my screen it looked ok but I see that the current state won't work for everyone. If you have any ideas on how to resolve that, let me know.

RobWalt avatar Feb 06 '24 06:02 RobWalt

@Jondolf just addressed the last issue in my lunch break 👍🏼

RobWalt avatar Feb 06 '24 13:02 RobWalt

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

github-actions[bot] avatar Feb 06 '24 16:02 github-actions[bot]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

github-actions[bot] avatar Feb 06 '24 16:02 github-actions[bot]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

github-actions[bot] avatar Feb 06 '24 17:02 github-actions[bot]

Meshing for most 3D primitives was added in #11688, so this example should probably be updated to reflect that

Jondolf avatar Feb 12 '24 21:02 Jondolf

@Jondolf done 👍🏼

RobWalt avatar Feb 13 '24 08:02 RobWalt