Jonathan Lindegaard Starup
Jonathan Lindegaard Starup
> What should I know before I start my review? Not anything specific I can think of
The diff looks big but ive just moved code around. And its isolated to the java lookups Instead of `isKnown -> lookup` its now `lookup (using isKnown, it might now...
you think its okay @mlutze? its only concerning behaviour inside the java constraints
more minimal, import before is required to trigger ``` import javax.swing.SwingUtilities; //import javax.swing.SwingUtilities; import java.lang.Runnable; ```
Nice if pure code was somewhat immue to "it works on my machine"
> I understand Env as read-only from system properties, but Sys as writing. That means that if you have Sys you also have Env when it interacts with the system...
just to have more than one error and fit into the framework. is there is middleway between this and just throwing ice?
@magnus-madsen now in a version a la `TypeVerifier`
Damn really? Maybe it helps cache stuff to merge the passes into a single pass, but otherwise, I don't know. We can also just run it once for the standard...
Turns out one pass really matters. Now its 11 minutes. But as I said, we can also just run it once on the standard lib instead of every test?