Jonas Toth

Similar issue: #1120, integer promotion is kind of a problem :see_no_evil:

Out of interest: could we find patterns of the misuse? Clang-tidy could catch the `string_view sv = s + "string";`. So even if we can't find all for now, we...

> The misc-dangling-handle check in clang-tidy relies on the user to tell it which types have reference semantics; that is indeed not perfect but it's significantly better than not catching...

Thanks for your fast reply! One additional oddity is, that the whole process works when building "normal", without that package management stuff, and if the build-type is not "Gentoo", but...

> Wow, I can't believe that somebody thought it was a good idea to rename `leapseconds` to `leap-seconds.list`... That seems to be a linux thing? Ubuntu 18.04 has it, too....

Ok. No pressure from my side! Once you have a fix, it would be great to note this commit, that i can test the patch and eventually apply it in...

The tests to pass now. Both in the package environment as well as the manual reproduction with normal user settings. Thank you for the fast fix! Are you planning a...

The guidelines recommend to use parenthesis for logical conditions to make the order of evaluation clear even to beginners that are not familiar with c++. I feel that alternative tokens...

What would be a good reason?

> If you're working on a piece of code that always uses the alternative tokens, be consistent. Thats a good reason.