JonasJebing
JonasJebing
I updated the issue with more alternatives ("Write a custom Serializer" and "Not adding anything to envy"). Note that generally I would be willing to write a PR for this...
@bottlerocketjonny are you still working on this? If not, I'd like to work on a PR for this feature.
It doesn't seem too complicated so far. I just happen to be taking some vacation but I am hoping to have at least a draft PR within 2 - 3...
Thank you for all the pointers and comments on this PR @marcphilipp. I've addressed all your comments. Could you have another look?
@marcphilipp could you review again? I applied all suggestions and added a release note.
@marcphilipp do you know how to fix the DiskLruCache issue on the Windows check? I see some PRs, like #4120 are having the same issue.
@marcphilipp could you review the [latest changes](https://github.com/junit-team/junit5/pull/4045/files/a986bba97bfbf0feb343b79946f22d06e1df4dba..dd6b55adc7ab5b88b050253ea4366a580e3f6805)? Like [you suggested](https://github.com/junit-team/junit5/pull/4045#discussion_r1820589629), the ArgumentCountValidator now only fails the invocations that have too many arguments and still runs the other invocations that have...
> Looks good! I've only two small suggestions. Please let me know if you have time to do those or whether I should take over. Thanks! I'll make those changes...
@marcphilipp could you merge the PR? And of course feel free to [review the small change you suggested](https://github.com/junit-team/junit5/pull/4045/commits/906881ce774836fb64f540782be3edc09aef113b).