Jonas comments

Results 145 comments of


                                            Jonas

ref: isParentRemoved to cache subtree

Sounds good, I went ahead and reverted the change to the profiling script

ref: isParentRemoved to cache subtree

@Juice10 Can we merge this, or do we need a separate review?

ref: isParentRemoved to cache subtree

Thank you @Juice10!

perf: coerce blockSelector and blockClass to a single concept and reduce branching

Discussed with maintainers: we can make this more efficient by constructing a validation function that is then passed down to the serializers

perf: coerce blockSelector and blockClass to a single concept and reduce branching

Closing this in favor of a better alternative

ref(profiling): Conditionally shim cjs globals

~I need to add an e2e test before this can be merged~

ref(profiling): Conditionally shim cjs globals

@AbhiPrasad mind taking another look, I added the check to run experimental modules and bumped to v22 of nodejs for profiling e2e tests

ref(profiling): Conditionally shim cjs globals

Thanks for the reviews @AbhiPrasad @mydea!

reactComponentAnnotation creates Bad Requests (400) when fetching from external data source such as Algolia

Tagging @Haroenv - this looks like an issue on our end (prop bleeding?), thought I would expect the Algolia SDK to guard from this.

reactComponentAnnotation creates Bad Requests (400) when fetching from external data source such as Algolia

@smeubank I think we generate these annotations, but then they somehow end up in Algolia, which I would expect the Algolia SDK to guard from (unless we are doing something...