Jon Rowe comments

Results 306 comments of


                                            Jon Rowe

output matcher: add `as_tty` method to make the simulated stream behave as a TTY

I think its reasonable to respect the original `tty` behaviour as we're just capturing the output, another option would be to explicitly define this with something like `expect { ......

output matcher: add `as_tty` method to make the simulated stream behave as a TTY

Great! Thanks!

Handle dynamic mocks specially for null-object doubles

Released in 3.13.2

Get test coverage of all code that's not version-specific up to 100%

I'd favour adding a check to our matrix running on the latest Ruby only, please note until I finish the monorepo work we need to apply such changes in `rspec-dev`...

Get test coverage of all code that's not version-specific up to 100%

> Meaning 3.3 for now, and not ruby-head? Yes, for us `ruby-head` is for "pre warning" of upcoming issues rather than enforcing any rules [and is generally allowed to fail]

New matcher idea: `match_pattern` for Ruby's pattern-matching

Migrated to the monorepo rspec/rspec#149

Fix Include Matcher For Ranges

This has been migrated to the monorepo, given that the blockers were largely legacy rubys that RSpec 4 won't support I hope to merge this in relatively quickly, sorry it...

Prevent custom matcher is called twice without compound

Thanks for starting to tackle this, the issue as I see it is somehow this method is being responded to by the matcher, this is what needs to be fixed...

Prevent custom matcher is called twice without compound

> Hello @JonRowe thank you, sure I can raise NoMethodError rather than using RSpec.warning. WDYT ? The fix should be to find where the method is being responded to and...

Prevent custom matcher is called twice without compound

Migrated to the monorepo as rspec/rspec#148