Jon Rowe comments

Results 306 comments of


                                            Jon Rowe

Custom object display formatting

I'd support a PR exposing an API allowing you to customise the output of different types, the Differ would be a better place to house that than Formatters though

Custom object display formatting

Closing due to inactivity during the monorepo migration, but if someone wanted to revisit this they'd be welcome.

Extract Countable to a reusable module

I'm not sure we want to make it a public api though...

Extract Countable to a reusable module

Mocks cannot depend on Expectations for such core functionality, if you do want to extract it, then it would need to go to support. The current implementation is not suitable...

Extract Countable to a reusable module

Closing due to inactivity during the monorepo migration, but feel free to reopen there if someone works on it.

Add the ability to add a "chain" to an existing matcher

We don't really encourage people to monkey patch or inherit from our matchers, they are not even encouraged to know the class names (by which I mean they are tagged...

Add the ability to add a "chain" to an existing matcher

If you want to investigate this further I don't mind, if you want to close I don't mind, I just wanted to point out the potential pitfalls :)

Add the ability to add a "chain" to an existing matcher

The first is no better/worse than @benoittgt's ideas, the second overrides our implementation and would have the same problems with other uses, but at least it would be deliberate by...

Add the ability to add a "chain" to an existing matcher

> Does it? It does if we define `have_key`

Add the ability to add a "chain" to an existing matcher

> This technique allows both to extend an existing matcher, or to extend in a subclass without affecting an existing matcher. This is my point, it doesn't prevent affecting an...