Jon Rowe comments

Results 306 comments of


                                            Jon Rowe

Diff string arrays like other arrays

Migrated to monorepo as rspec/rspec#101

Add special case for Class.new method signature that should use initialize signature instead

This is the wrong place for this I feel. We handle this specifically for rspec-mocks at the time of stub creation, we do this with: ``` def self.applies_to?(method_name) return false...

Add special case for Class.new method signature that should use initialize signature instead

I'd rather rspec-support did not magically return a different method handle from whats requested as thats not the purpose of it. If theres a specific missing handling of `new` to...

Add special case for Class.new method signature that should use initialize signature instead

> how come it's not catching the above case? Presumedly because it has never supported the above case.

Add special case for Class.new method signature that should use initialize signature instead

To clarify further, we added support for `new` => `initialize` for verifying doubles, `and_call_original` never got support for it, we would need to support it there. You need to check...

Add special case for Class.new method signature that should use initialize signature instead

I'm going to close this, apologies for letting it hang for so long I think the fix for this needs to be in rspec-mocks, I've created a new issue over...

Demonstrate issue with large nokogiri documents

@benoittgt this is a bit confusing because of the rebase, but its worth leaving open as its an issue rather than a stale PR

Suggestion: Alternate Hash differ output

I'm closing this for now as not planned due to inactivity and as part of migrating to the monorepo, we do intent to make the differ pluggable to be able...

Bug: Issue with Differ due to new ObjectFormatter class

Closing due to inactivity as part of the monorepo migration, there are several similar issues about improving the differ and we intend to make this pluggable.

Inform user about deprecated doc

Do you mind if we transfer this to the website repo? Seems like an issue for that? We would have to regenerate / edit the documentation to add such a...