Jon Rowe
Jon Rowe
Mm.. I'd like a fix here, even if its just us issuing a warning about invalid escape chars...
(We know our Windows support isn't great, anything we can do to improve it is a good thing..)
I'd like to see if 2.6 has this issue for us, or otherwise replicate it on appveyor, @benoittgt do you want to take care of that?
Closing due to inactivity and Ruby 2.7 is long gone.
:wave: @benoittgt this is on my list to tackle, it will just be that we're not properly escaping / passing the pattern to the shell, its known to be problematic...
Hm, ok, this is slightly more complex than I realised... We are having to parse the original cli and then re output it, but we are correctly escaping the shell...
Can you give #2643 a go to see if it solves your issue?
I can't replicate it either now, previously I had files failing but escaping them on input works fine, without a reproduction I'm not sure I want to merge #2643
@myronmarston the linked issue explains why shell runner was used at all, the OP ran into a deadlock with the fork runner
I'm going to close this, its been a while and I don't think there was a good reproduction