Jon Rowe comments

Results 306 comments of


                                            Jon Rowe

class spies fail to verify when chaining an instance method onto a class method that returns an instance

The advantage of using a spy is to set the method expectations after the methods have actually been received, e.g. it enables the `have_received` matcher, if you don't need that...

class spies fail to verify when chaining an instance method onto a class method that returns an instance

Closing due to inactivity during the monorepo migration

An exception is raised when invoking an `any_instance` expectation on a subclass that has an `any_instance` stub on its parent class

Closing due to inactivity during the monorepo migration

[Feature] General stubbing with `.should_receive(anything)` or `double.as_null_object(:default_return)`

Closing due to inactivity during the monorepo migration, but if someone wanted to revisit this they'd be welcome.

More thread safety fixes needed

Given what you've described, it's more likely the expectation is being verified before your method call is "complete".

More thread safety fixes needed

The moment `component.search('query', callback)` returns to RSpec, the expectation will be verified, the number of calls that RSpec has received by then will be used. You can fix this by...

More thread safety fixes needed

That doesn't apply here, RSpec can't see beyond it's own thread AFAIK

More thread safety fixes needed

Closing during the monorepo migration as there is an issue migrated from rspec-core.

Reconcile duplicatated (but slightly different) matchers between rspec-mocks and rspec-expectations

I'm wary of making `rspec-support` an uber gem that basically morphs into an `rspec` not split in three. I'm not against this specific change, just noting my wariness.

Reconcile duplicatated (but slightly different) matchers between rspec-mocks and rspec-expectations

I'd support option 4 in the long term. I'm not sure I like this myself but I'd like to suggest: 5) Create an `rspec-matchers` gem that contains the matchers for...