Jonathan Cook

It would be nice to put into the mvn configuration a value representing overall coverage which causes mvn to fail your build if it is not satisfied, that way it...

Maybe it is to do with this. ``` 11:33:07.196 [pool-2-thread-3] WARN com.github.timurstrekalov.saga.core.htmlunit.QuietJavaScriptErrorListener - Error loading script referenced on page file:/home/password/projects/frontend-html5-fe-refactor-jonathan-cook/layers/front-layer/target/test-classes/com/odigeo/front/javascript/tests/test.html. Script URL: file:/home/password/projects/framework/src/main/resources/META-INF/resources/static-content/_versionedByRelease_/js/odigeo.ui.js, message: Unable to download JavaScript from 'file:/home/password/projects/framework/src/main/resources/META-INF/resources/static-content/_versionedByRelease_/js/odigeo.ui.js'...

pom snippet. if it can't find the scripts why does it generate a report? I saw some commit related to phantomjs and local http servers? ``` com.github.timurstrekalov saga-maven-plugin 1.4.2 test...

Ok thanks, but I'm not using a local server. We are reading from the file system.

I fixed this error but still no change in the metrics and a different ERROR, do these stop the metrics being generated. ``` 15:50:54.620 [pool-2-thread-1] ERROR com.github.timurstrekalov.saga.core.htmlunit.QuietJavaScriptErrorListener - Script exception...

Looks like related to https://github.com/timurstrekalov/saga/issues/89 and https://github.com/timurstrekalov/saga/issues/86 so can probably conclude it doesn't work with mocha-phantomjs

I have experience with mocha-phantomjs but what would I need to do to start experimenting or extending saga? I would be happy to contribute :)

Thanks. One quick question, I noticed this test in DefaultCoverageGeneratorIT @Test @Ignore public void test_instrumentAndGenerateReports_with_phantomjs() throws Exception { Seems to be ignored and if I remove it fails, this is...

Hi, I've had some time to play with this and appears to work with the existing phantom functionality. I created a new java unit tests and js files and it...

@timurstrekalov - Thanks Sorry for the stupid questions, so I have it working in a unit test but if I add this for example to my pom.xml ``` javascript http://10.248.40.101:8234/${basedir}/src...