Joël Galeran

Results 85 issues of Joël Galeran

Uniform cleanup on all "signatures" we have

Basic suggestion was implemented in https://github.com/prisma/language-tools/issues/1159 Currently, suggests `[]` or `dbgenerated()`, but nothing inside `[]` It could suggest `true` or `false` for `Boolean[]` like done for `Boolean` And could also...

kind/improvement
topic: autocompletion
domain/schema

The error ``` Run node scripts/e2eTestsOnVsix/check_for_new_release.js 31.0.375 /home/runner/work/language-tools/language-tools/scripts/e2eTestsOnVsix/check_for_new_release.js:23 throw new Error(`Expected two arguments, received ${args.length}`) ^ Error: Expected two arguments, received 1 at Object. (/home/runner/work/language-tools/language-tools/scripts/e2eTestsOnVsix/check_for_new_release.js:23:11) at Module._compile (node:internal/modules/cjs/loader:1101:14) at Object.Module._extensions..js...

kind/improvement
tech/typescript
team/schema
topic: ci
topic: internal

Related https://github.com/prisma/language-tools/issues/968

This is maybe a particular example where the warning text comes from prisma-fmt and includes a warning, the link is not clickable. ([related](https://github.com/prisma/migrations-team/issues/275)) in insiders v31.0.378 Not sure if we...

kind/improvement
topic: linting
domain/schema
topic: diagnostics
status/needs-upstream-support

## Problem formatOnSave is false by default ## Suggested solution I guess we could try having this in the extension https://code.visualstudio.com/api/references/contribution-points#contributes.configurationDefaults >Contribute default language-specific editor configurations. This will override default...

kind/improvement
topic: formatting
topic: vscode
topic: prisma-fmt
team/schema

It could be nice to add some commands like - Open Studio - Generate? - ... So a user could call some CLI commands from VS Code command palette https://code.visualstudio.com/docs/getstarted/userinterface#_command-palette...

kind/feature
topic: vscode
team/schema

New version is currently failing with https://github.com/prisma/ecosystem-tests/runs/5976145513?check_suite_focus=true#step:6:316 ``` $ jest FAIL ./index.test.js test generator ✕ should produce same prisma ts file for same Prisma schema (5 ms) ✕ should produce...

tech/typescript
kind/tech
team/client
topic: optional-test

This old project had a list of interesting images: https://github.com/prisma/binary-tester/tree/master/platforms Running on the pipeline at: https://buildkite.com/prisma/binary-testing ``` alpine.build alpine.node alpine.raw alpine.run amazonlinux.node amazonlinux.raw archlinux_base.node archlinux_base.raw centos.node centos.raw centos:7.raw debian.build debian.node...

kind/tech

We will need to duplicate the current netlify-ci test and select the image like here https://app.netlify.com/sites/prisma2-e2e-tests-netlify-ci/settings/deploys It's possible we need to update these https://github.com/prisma/prisma/blob/d171f8fd39ecead293ea85afe38578c10dd47102/src/packages/client/src/generation/generateClient.ts#L254-L255 https://github.com/prisma/prisma/blob/d171f8fd39ecead293ea85afe38578c10dd47102/src/packages/client/src/generation/utils.ts#L373-L375 Because I think we would...

kind/feature
topic: ci