JohnnyMorganz
JohnnyMorganz
Yeah I think so. The problem is just that we should attach multiple documentation comments if they are single line comments. The access to comment locations that Luau gives us...
We already support document links as part of the protocol, and we add these for require statements - https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_documentLink Are these not sufficient for your usecases? For example in vscode...
I think this might be a Luau issue which is best to report upstream. If they say it isn't then I'll dig deeper
Moved this upstream: https://github.com/luau-lang/luau/issues/1520
Apologies, but if it's not too difficult could you split out these different features + bug fixes into separate PRs? It makes it a bit easier on me to review,...
Fair enough Could you also write some test cases for the bugs you fixed and the 2 new features you added?
So sorry for the delay, will try to take a look this weekend
FWIW, still waiting on the comments being resolved here before merging this. Let me know if there are any issues with it, I can also take a look
Cool no worries, just wanted to double check you weren't expecting anything since I noticed you're still merging main into this PR
Please provide some reproduction steps since unforunately there is not much I can do to diagnose this otherwise