zz

It's kind of hard to write unittest for core logic as it uses thrift. I tested it manually, it worked well with both sync/async client. Please review it when you...

@turcsanyip Any chance to review it? It shouldn't impact any existing code. Thanks

@mpercy Could you please help with the review? Thanks

Please see the attachment for UTs result [FLUME-3258-UTs.txt](https://github.com/apache/flume/files/5032115/FLUME-3258-UTs.txt)

The failure seems not to be caused by patch https://builds.apache.org/job/flume-github-pull-request/org.apache.flume$flume-ng-tests/82/testReport/junit/org.apache.flume.test.agent/TestConfig/testConfigReplacement/

@majorendre Thanks for the patch, will add more tests. @turcsanyip Will test it and get back to you later.

@szaboferee Sure, will probably update the patch today with more tests

@turcsanyip The failure of TThreadPoolServer is called by wrong socket type (should be blocking server socket), fixed now. Thanks

Hi, I had updated the patch, please review it when you get a chance, thank you!

@szaboferee Ah, sorry, my bad. I had only clicked into the first link and it shows 500 erros. So I thought it was not my patch's problem by mistake. Now...