Cesar Soares

Results 16 comments of Cesar Soares

Hi there, can someone please take a look and let me know if this is going in a reasonable direction? @vnkozlov - is this more or less on the lines...

> This is good starting point. To have new "Phi" type node to collect information about merged allocation. > I need more time to dive into changes to give review....

> After looking more on changes I noticed that you exit compute_escape() before adjust_scalar_replaceable_state() is called. No worries. I'm currently working to make `reduce_allocation_merges` be executed as part of compute_escape...

Thanks for taking a look @navyxliu . I'm working on an improvement (and fixing a bug) and I'll include your suggestions in the next push.

Hi @vnkozlov , @navyxliu - I think I addressed all your comments so far. Can I ask you to please take a look again? I made several modifications for fixing...

>I currently found one issue we need discuss - merge allocation of different subclasses (of the same parent class) which may have different number of fields. Current implementation assume objects...

@vnkozlov - Thank you for clarifying that. I've been playing with lifting the restriction and I actually found a corner case: ``` public static Class test(boolean c1, boolean c2, boolean...

> @JohnTortugo Yes, you would need to construct Phi when you replace RAM with SafePointScalarObjectNode. Hmm, may be you would need to construct Phi in other cases too (getClass intrinsic)....

Hi again @vnkozlov, I ended up giving up on adding support for merging allocations of different subclasses. I think the current version of the patch already covers some reasonable ground...

Thank you for taking a look @vnkozlov . I'll address your comments asap.