Yuki Okushi
Yuki Okushi
> This means that libstd is either stuck on 0.2.79 for indeterminate amount of time or we need to figure out a way to support either version of musl or...
So, we currently detect FreeBSD version, like: https://github.com/rust-lang/libc/blob/4c0a7e5b7ca949088a0ba17784fb043a22e4537e/build.rs#L122-L145 I wonder we could also detect musl version and separate `time_t` definition.
Do you think this breaks the existing usage? If so, I'd like to provide this only on 1.0 as it's a breaking change.
I'm not sure why this change is _needed_ as that function should be usable currently. For instance, it's normally used on the user codebase: https://github.com/nix-rust/nix/blob/b4d4b3183b75addf7cad83c57994a62a89235ed4/src/sched.rs#L194-L201 > I'm not certain, but...
If it's usable then I don't see any strong reason to change. Could you show some situation it should be changed?
I don't think it's a _bug_ but an improvement, though. So, adding `unsafe` helps some usage (and it doesn't break any build), I'm happy to accept that change. Therefore I'd...
@wllenyj We have to create a repo first. @cathay4t I'm not sure how we use https://github.com/rust-netlink/new-crate-review, could you clarify its usecase?
@howjmay Great, go ahead!
@AzureMarker Could you take a look at this? A breaking change (changing some fields on some env) would be required to fix it, but I guess you're using this struct.
Quick solutions I come up with is either 1) limit the number of cfgs or 2) ignore cfgs if the number of cfgs is enormous (this has a trade-off around...