libc icon indicating copy to clipboard operation
libc copied to clipboard

backport: add stabilized HermitOS interface

Open stlankes opened this issue 1 year ago • 4 comments

HermitOS is a unikernel and its interface to the kernel is provided by https://crates.io/crates/hermit-abi. In the meantime parts of the interface is stabilized and we want to integrated it into libc. Unstable version will be still provided by hermit-abi.

This PR is a backport of #3724 and doesn't have breaking changes. It just provides new functions to enter the kernel.

stlankes avatar Jul 06 '24 20:07 stlankes

r? @JohnTitor

rustbot has assigned @JohnTitor. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Jul 06 '24 20:07 rustbot

I forgot the error numbers and added to this PR.

stlankes avatar Jul 13 '24 07:07 stlankes

Do you think this breaks the existing usage? If so, I'd like to provide this only on 1.0 as it's a breaking change.

JohnTitor avatar Jul 13 '24 08:07 JohnTitor

No! I am pretty sure.

stlankes avatar Jul 13 '24 09:07 stlankes

Any update on this? We want to use it Mio as well.

Thomasdezeeuw avatar Aug 06 '24 08:08 Thomasdezeeuw

@stlankes I picked up the first commit as part of my backport bonanza, in https://github.com/rust-lang/libc/pull/3814. The second commit (5c7c7824, "add missing error numbers for HermitOS") seems like it is something that should go to main too. Could you create a new PR targeting main that makes that change? Comment @rustbot label +stable-nominated so it gets picked up in the next backport.

tgross35 avatar Aug 13 '24 00:08 tgross35

This can probably just be closed once you create the new one, but

@rustbot author

tgross35 avatar Aug 13 '24 00:08 tgross35

:umbrella: The latest upstream changes (presumably #3814) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 13 '24 02:08 bors

The backport of the first commit merged. I am going to go ahead and close this - but please feel free to put up a new PR with 5c7c7824253e6f3f4735cf253fe2c7e60ab94cd0, as mentioned above.

tgross35 avatar Aug 13 '24 02:08 tgross35

Thanks @tgross35

Thomasdezeeuw avatar Aug 13 '24 08:08 Thomasdezeeuw

@stlankes I picked up the first commit as part of my backport bonanza, in #3814. The second commit (5c7c782, "add missing error numbers for HermitOS") seems like it is something that should go to main too. Could you create a new PR targeting main that makes that change? Comment @rustbot label +stable-nominated so it gets picked up in the next backport.

I will do it next week. After my vacation...

stlankes avatar Aug 15 '24 20:08 stlankes