Yuki Okushi
Yuki Okushi
Thanks for the PR! However, I don't think adding such a header-based module is not a good thing here. We already have the target-based (e.g. arch, OS, etc.) structure and...
I'm repeating but it adds an entirely different structure, and it confuses contributors, like "which ways should I follow? target-based or header-based". This would also add a lot of cfg_if...
Fair enough, thanks! @bors r+
Failed on i686: ``` cargo:warning=/checkout/target/i686-linux-android/debug/build/libc-test-aa3b5ef22d9f3b80/out/main.c:25113:75: error: use of undeclared identifier 'AT_MINSIGSTKSZ' cargo:warning= static const unsigned long __test_const_AT_MINSIGSTKSZ_val = AT_MINSIGSTKSZ; ```
Changing types is a breaking change and we don't ship it on minor releases. I'll revisit once we decide to do a major release.
Note that there're some overrides with https://github.com/rust-lang/libc/pull/2406.
Could anyone give me a summary of the discussion here? I'd like to help merge this but don't have enough context.
Failed on musl: https://github.com/rust-lang/libc/actions/runs/8846424497/job/24292411184?pr=3630
Yes, it doesn't run on the `fixed` dir, that dir was just added as per #154. I doubt all of them are _valid_ failures as we don't punish a valid...