John

Results 8 comments of John

Here's my hacky/fragile attempt, though I can't break it anymore: https://github.com/JohnRigoni/codeium.vim I apologize to the devs as it needs to ignore `call codeium#server#Request('AcceptCompletion', {'metadata': codeium#server#RequestMetadata(), 'completion_id': current_completion.completion.completionId})`, but hopefully we...

Should I have based this branch on develop? I did not see any conflicts or other changes so I did not think anything of it.

I moreso meant that my branch was initially based off master. I did not see any differences in the PR besides my code changes so I did not create a...

It appears using `set_mod()` was leaving modifiers still active, hence last commit's test that ended in an unrelated keypress. It appears the only solution is to use oneshot modifiers, though...

Hello, I have a fix for this behavior here https://github.com/JohnRigoni/qmk_firmware. I am going to do some further testing/tweaking then make a pull request.

I also wanted this feature. Here is a working [proof of concept](https://github.com/JohnRigoni/qmk_firmware). Theses changes can be applied to the ZSA firmware as well.

This should sort out both the concerns you raised. 1: This change does respect TAPPING_TERM and I have added tests for every permutation of key roll (finally got the hang...

Hi @NikGovorov, glad you are finding the changes useful. There should be no issue running both together, I have been doing so since I made this PR! I plan to...