Johannes Marbach

> Out of curiosity, are you making use of the SSO login method in an app? I thought it was to be deprecated, and as such I would encourage to...

> Do you think it is possible to write tests for these new methods? I can probably do that, yes. However, @bnjbvr suggested that the architecture should maybe be changed...

> To clarify, the state machine I was talking about was to return a small object that starts the SSO login, with a single method "finish()" that received the right...

I'm struggling a little to make this work because I'm not sure how to properly move the things needed to complete the login from the service into the returned object....

@bnjbvr do you have any thoughts on how to best proceed here?

Ok, I think I _might_ have it. Adding tests for this part turned out somewhat tedious. So I only added one to verify the login URL so far.

I moved everything over to `Client` due to https://github.com/matrix-org/matrix-rust-sdk/issues/3579#issuecomment-2181435689. I think the clippy error might only be fixable once `AuthenticationService` has been removed and `Client` made public. So this probably...

@Hywan this is ready for review now. CC @pixlwave in case you'd like to take a look as well.

@Hywan is there anything else you'd like me to change before this can be reviewed?

Looks like the login screen is currently fixed to use the light theme in https://github.com/matrix-org/matrix-react-sdk/blob/johannes/newline-pills/src/settings/watchers/ThemeWatcher.ts#L102 and https://github.com/matrix-org/matrix-react-sdk/blob/johannes/newline-pills/src/settings/controllers/ThemeController.ts#L33. It doesn't look overly attractive after commenting these lines though and will likely...