Johannes Buchner

Results 227 comments of Johannes Buchner

Actually, if I read correctly, these ICC profiles are meant to adjust to the particular viewing device. Wouldn't it be more objective to ignore them? Probably I am misunderstanding this.

Two suggestions: 1. change the code so that when ImageCms is not loadable, it does not use this functionality, either with hasattr or a try-except(ImportError) construct. 2. try to modify...

I agree with what you say. I think there is a benefit though of passing PIL objects however, as one can apply additional image modifications beforehand. If I understand you...

> For this PR, do I also need to update `data_files` in `setup.py` with the new test images? If you use them only for testing, no, if you want them...

I would be happy to include this as a single preprocessing helper function. A section in the README should explain why and how to use it. This will make it...

Sorry for the late update, added a LICENSE file and shortened the description to one sentence.

@dshoman could you have a look at the following issues, please? * Readme should include contact * python scripts need `pip install natsort` which is not yet described in the...

> @JohannesBuchner of course, I will add the updates in one new pull request. Yes, please. > * For the `natsort` requirement, should this be mentioned in the main readme,...

Please have a look at https://johannesbuchner.github.io/BXA/ for how it looks now and let me know if you want any changes.

One thing I don't particularly like in the current navigation on the left is that the titles are so long and there is no clear separation. Bullet points would help....