Johann150

Results 149 comments of Johann150

I am currently waiting for the things from #145 to be modified into this PR.

Please note the `tools/` directory is mostly contributed by others. This also applies to the Dockerfile. Since I have neither experience with nor interest to get to know Dockerfiles I...

Its fine to put the Dockerfile in the root directory.

Thanks for your contribution! Since `Vec` is compatible with `impl IntoIterator`, and likewise for the other function, I think we could even just replace the existing methods instead of creating...

No, there are currently no C bindings. I don't think there are plans to add some.

Please note the CI is failing because of dependencies not being compatible with the oldest tested against Rust version (1.40.0).

The reason for using a BTreeMap was this comment https://github.com/brendanzab/codespan/blob/629d35a4c9f30236a2adbc5773c756d23d1775d7/codespan-reporting/src/term/views.rs#L98-L100 I would not call it an "intermediate `BTreeMap`" because its used afterwards, like the vector the above comment is referencing....

@brendanzab any feedback on this?

The issue with this is that you would need the `Files` because the Diagnostic itself only stores a byte offset into the file. This is why the locus calculation is...

I think so, but I don't see how that would be useful. But it might make sense to implement such a function on the Diagnostic anyway because that would separate...