Johan Mabille

Results 364 comments of Johan Mabille

Hi @marty1885 , Sorry for the late review. The implementation of the parser itself looks good to me (maybe we could simplify it with `std::regex` but I'm not sure and...

@Zsailer arf sorry for that! This came out when discussing the Handshake pattern, we need an additional field in the kernelspec and I thought it could be the opportunity to...

More changes to come, but I need to educate myself more to JSON schemas :sweat_smile:

Kind ping on this, I think this is ready for a final review: - The [Jupyter Schema repo](https://github.com/jupyter/schema) has been created, it will hold all the schemas for Project Jupyter...

The JEP has been approved. Yes: 9 No: 0 Abstention: 0 No vote: 1 Merging

Hi @paddymul - @JohanMabille from the @jupyter/software-steering-council here. We're working through old JEPs and closing proposals that are no longer active or may not be relevant anymore. Under Jupyter's new...

Thanks! We also have [FFTW bindings](https://github.com/xtensor-stack/xtensor-fftw), although not maintained for a while. It might be interesting to compare the results and performance.

> To avoid a risk of inconsistency the document store should not be accessed directly This constraint leads to duplicating the Store API in the StoreManager, therefore I agree that...

> I think there should maybe be a dedicated 2-d matrix as it would be easier to interface with solvers if the storage is classically in three contiguous arrays. If...