WIP: New CSV parser

Open marty1885 opened this issue 7 years ago • 3 comments

See #1280.

Dec 09 '18 13:12 marty1885

Thanks for this work @marty1885! We will be reviewing this tomorrow!

Dec 09 '18 20:12 SylvainCorlay

Hi @marty1885 ,

Sorry for the late review. The implementation of the parser itself looks good to me (maybe we could simplify it with std::regex but I'm not sure and this is something I don't master yet), my only remark is about the API.

Dec 21 '18 08:12 JohanMabille

@JohanMabille Thanks. I'll change that. My main concern is in my latest comment #1280 . May you check it out?

Dec 23 '18 14:12 marty1885