Joseph Ho
Joseph Ho
Hello @alya! I've added the new custom unread banner, please have a look.
Found edge cases where the new custom unread banner would display instead of the default preserved reading state banner on searches and near tags. Updated the commit to fix that...
> The logic for when to show it can be just when you have unreads in the current view (same as with the current banner). And we can just never...
Opened discussion in [CZO #design ](https://chat.zulip.org/#narrow/stream/101-design/topic/UI.20redesign.3A.20scroll.20down.20and.20unread).
Hello @alya! This PR is ready for another manual review :)
Seems like newer ones were merged but it doesn't raise a merge conflict error. Fixing it right now!
@alya I've rebased and changed up the migrations. Ready for testing now!
Sure! I planned on doing it as a follow up after this PR.
Oopies, I thought I had tested it before but I guess not.
Hey @alya. This PR could be marked as close as the issue has been completed by another PR.