Joel Speed
Joel Speed
@jcpowermac Are you planning to continue with this feature promotion?
Since @saschagrunert has said this is good from his side, I'll now take over the API review. Since it's shift week, I'm not expecting to pick this up until Monday
Proto changes appear to be unrelated, verify thinks changing them is wrong and is suggesting to change them back Possibly running with a newer or incompatible version?
/test lint
API types look good, but it looks like some of the test cases are expecting things that aren't true (optional port), so lets get those fixed up and please squash...
Changes here LGTM, there are however some code generation issues by the looks of it
Regarding whether this should merge or not, I currently haven't seen any of the listed EP approvers chime on the EP for review, nor anyone from the kube-apiserver-operator owners file....
Defaulting to optional on `omitempty` is a historic mistake and not one I'm keen to repeat. Latest API guidelines in upstream kube do not differentiate `omitempty` for optional and required...
I'm personally a -1 on this. It doesn't align with the properties of openapi, the CRD schema, or the work that the declarative validation folks are doing. We also have...
Does it lead to ambiguity for lists/maps? If I have a list of strings, does length apply to the strings, or the list itself? If I have maps, does the...