Joel Speed

Results 1017 comments of Joel Speed

https://github.com/openshift/api/pull/2541#issuecomment-3432923941 Per comment on the implementation, we would like to keep the `expected` as an explicit test option and not default it for now

Verify should only fail on this repo if you have out of date generation, I can see in the logs it's showing a diff so you'll need to investigate this

/lgtm cancel /hold @ardaguclu @flavianmissi While I appreciate the team review and LGTM, please don't `/lgtm` on this repo until an API approver has had a pass. We are trying...

No worries @ardaguclu, it's a different process that we are trialing and I expect more repos to take on in the future. I'm hoping we can make it more obvious...

@opokornyy Looking at the data, we have no testing on either metal or SNO, does this feature work on those platforms? Should we be adding testing for them?

Still not seeing metal dual stack or ipv6 showing in here, any thoughts?

> We haven’t added these yet. If they’re required, we can onboard them as well. Yes please

Code changes are looking good, will need to now work towards getting enough signal to promote. Looks like AWS has had some issues with one test down to 78%, are...

Test results now looking close enough that we probably want to use gangway-cli to boost the runs to get the data in place and promote, WDYT @opokornyy?