Joel Speed

Results 945 comments of Joel Speed

/override ci/prow/verify-crd-schema Existing issues that cannot be resolved now /override ci/prow/verify-feature-promotion This feature is only applicable to the metal platform and is only being tested on dual stack due to...

/override ci/prow/verify-crd-schema Existing issues that cannot be resolved now /override ci/prow/verify-feature-promotion This feature is only applicable to the metal platform and is only being tested on dual stack due to...

This has been a topic that has come up a few times throughout the OAuth2 Proxy project, and, I think changing it would be a breaking change. We know in...

> the refresh happens more frequently? Is that a breaking change? Not everyone has the refresh configured and/or working correctly, so for certain users, it would limit the length of...

Looking at the results of the `lint` check here, a large number of these I know are auto-fixable, try `make lint-fix` on the PR and it should bring a lot...

Ahaa! [This is something I just merged](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2012/pull-ci-openshift-api-master-lint/1869781716126666752) which is showing that there is a diff between `make lint-fix` and what's checked in (that's what the git diff is showing), so...