Joel Speed
Joel Speed
Reviewing that, looks like we need to have the port in the service for it to be used as a health check right? https://github.com/kubernetes-sigs/cloud-provider-azure/blob/b8b4145fdaf3578616979437c60acc90ca4ec249/pkg/provider/azure_loadbalancer.go#L2145 So in that case, you'd expect...
I've tried the above today to no luck, if I specify a port annotation to redirect the health check port on my service to port 10256, it errors because there...
Cc @alexanderConstantinescu I know you've been working on improving disruption to services, could you check out this issue and see if you agree/if there's any more you can add
/reopen @feiskyer Did you get a chance to review my last comment?
Seems innocuous /lgtm Curious to know why this is a separate go module, wonder if one of the maintainers can explain why the clients need this bump separately, any way...
> The clients will be used in 4 branches. And we don't want to maintain 4 copies of azclient. So the idea is that the client library will be able...
/reopen /remove-lifecycle rotten CC @imkin @SandeepPissay could you please take a look at this PR?