cloud-provider-azure
cloud-provider-azure copied to clipboard
kubernetes-sigs
Bumps azclient to latest version
What type of PR is this?
/kind cleanup
Version vump
What this PR does / why we need it:
Bumps sigs.k8s.io/pkg/azclient to the latest version. This is to include changes from https://github.com/kubernetes-sigs/cloud-provider-azure/pull/5643
Which issue(s) this PR fixes:
Fixes #5558
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE
Hi @theobarberbany. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Seems innocuous /lgtm
Curious to know why this is a separate go module, wonder if one of the maintainers can explain why the clients need this bump separately, any way to work around it? Perhaps with go workspaces to avoid the needed bump?
{Unexpected error:
<wait.errInterrupted>:
timed out waiting for the condition
{
cause: <*errors.errorString | 0xc000269a10>{
s: "timed out waiting for the condition",
},
}
occurred failed [FAILED] Unexpected error:
<wait.errInterrupted>:
timed out waiting for the condition
{
cause: <*errors.errorString | 0xc000269a10>{
s: "timed out waiting for the condition",
},
}
occurred
In [It] at: /home/prow/go/src/sigs.k8s.io/cloud-provider-azure/tests/e2e/network/service_annotations.go:960 @ 03/13/24 12:40:51.061
}
Looks like there's a timeout - guessing it may be a flake or have something to do with the cloud being slow? Going to retry.
@nilo19: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.
In response to this:
/cherrypick release-1.29
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nilo19, theobarberbany
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [nilo19]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The clients will be used in 4 branches. And we don't want to maintain 4 copies of azclient.
The clients will be used in 4 branches. And we don't want to maintain 4 copies of azclient.
So the idea is that the client library will be able to be used across all supported versions of the CCM, but only actually maintained on the master branch? Gotcha
@nilo19: #5651 failed to apply on top of branch "release-1.29":
Applying: Bumps azclient to latest version
Using index info to reconstruct a base tree...
M go.mod
M go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bumps azclient to latest version
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick release-1.29
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.