Joel Dahne

I realize that this issue is quite old but I thought I would something as well. I think it would be beneficial to use one of the versions mentioned in...

After looking a bit more at this I realize that the issue seems to be that Symbolics.jl doesn't have a symbolic representation of π at all. So the issue is...

Actually I don't find one when searching for `pi` or `irrational` in the open issues. I got to that conclusion from [this post](https://discourse.julialang.org/t/symbolic-sqrt-2-and-sin-pi/58633). It is related to #497 but not...

Thank you for your comment! I agree that many people probably don't use JuliaFormatter, or use it with different settings. I also agree that there are certainly other ways for...

Sorry for joining the conversation late, I was pointed here from #52859. Regarding this part in the initial comment > However, the requirement for exactness means that the BigFloat precision...

After some digging I found that `ndigits` for `BigInt` uses `Base.GMP.MPZ.sizeinbase` internally, so that should be plenty fast!

Let me try to take a closer look at this today! Regarding the comment > do we actually care about giving the user the ability to specify rounding modes here?...

I would also propose to say that this change makes constructing a float from a rational "correctly rounded", instead of "exact". It seems more clear to me at least, since...

I also made a quick benchmark comparing this implementation for `BigFloat` with the one I proposed above. With the version in this PR I get ``` julia> @benchmark BigFloat($(5 //...

Sounds good! I don't have any further comments at this point!