Joseph Madamba

Results 148 comments of Joseph Madamba

> @ppy/area-client in your view, should the behaviour of clicking on difficulty icons on the carousel panels navigating to said difficulty be retained with this design? I think to some...

Have fixed most of the visual problems with slight code quality. I haven't done the splitting difficulty panel as I still don't really understand the `BeatmapCarousel` code in general after...

Have updated the design (and experimented with an animation): https://github.com/ppy/osu/assets/35318437/8ddd68cc-4c3b-4677-a2e0-3e5e126d98d5 Not really confident about my right arrow animation, but that's what I would do. The code quality has taken a...

Will try to update this with single diff display throughout the weekend.

Pushing with whatever progress I made in the past. Haven't addressed the dynamic shearing as commented in https://discord.com/channels/188630481301012481/188630652340404224/1182168002741948426, as it may be involved (i.e. to get the fancy dynamic shear...

> I though this was normal There's https://github.com/ppy/osu/pull/22052#issuecomment-1374427279, but the scenario above can be a reason to not have this behavior. Leaving @peppy to decide.

There's https://github.com/ppy/osu/issues/11142 and I do get a ~15->5s improvement on an M1 Air w/ 16 GB on master but that's the upper bound of https://github.com/ppy/osu/issues/4976#issuecomment-1304758801.

I've fixed the content overflowing to the border: | Before | After | | --- | --- | | | | I've kept the +2 on the top, even if...

Related: https://github.com/ppy/osu/discussions/30797 ``` [runtime] 2024-11-21 00:38:34 [debug]: Pressed (ExportReplay) handled by SaveFailedScoreButton. [runtime] 2024-11-21 00:38:34 [debug]: KeyDownEvent(F2, False) handled by GlobalActionContainer. [database] 2024-11-21 00:38:35 [verbose]: [?????] Beginning import from replay.osr......

Probably closing for the same reason as https://github.com/ppy/osu/issues/29731#issuecomment-2334529002 and the comment above (setting extra lives to 0) seems like a good compromise (if extra lives