osu
osu copied to clipboard
ppy
Initializing complicated storyboards is too slow
Describe the bug:
Starting play for this map with storyboard enabled takes a two and half minutes of one CPU core usage at 100%. This is too long to wait before play or retry. Disabling storyboard makes it load in less than 5 seconds.
OS: Arch Linux CPU: Intel Core i7-8750H @ 12x 4.1GHz GPU: GeForce GTX 1060 with Max-Q Design
osu!lazer version: revision 164b05abd6debb5b817d2f47620e593c006a24b2
Logs: runtime.log
We are very aware of performance issues with storyboard loading. In osu-stable loading of storyboards is incremental to offload some of this overhead, but we also have improvements to make in the parsing logic in general.
Does this mean I shouldn't open issues about poor storyboard performance with specific beatmap?
It's not specific to any beatmap. The more storyboard content, the longer it will take.
Does Update and Draw drop from 240 and 120 Hz correspondingly to 40 Hz both on ginkiha - EOS by alacat count?
This issue is very pronounced with this beatmap with it's storyboard enabled. It's been loading for over 15 minutes and used so much of the machine's memory that it starts swapping to disk sometimes.
tl;dr excessive memory usage upwards of 8gb
lazer 2019.1205.0
Intel Core i7-8750H
GTX 1060 Max-Q
12GB DDR4 @ 2666 MHz
Storyboards slow loading have been fixed close this issue. The map now takes 14 seconds to load at least on my computer. Freezing also doesn't occur anymore with large storyboard maps.
14 seconds is still too long. I would expect this to take 0-5 seconds on a powerful machine.
Maps provided in OP and in this comment are fixed by #27539.
Are there more which remain? May be worth mentioning those specifically else we can close this issue.
There's https://github.com/ppy/osu/issues/11142 and I do get a ~15->5s improvement on an M1 Air w/ 16 GB on master but that's the upper bound of https://github.com/ppy/osu/issues/4976#issuecomment-1304758801.
